Add Hyperdrive example with Nile database #18374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwenshap
requested review from
a team,
Oxyjun,
elithrar,
sejoker and
thomasgauvin
as code owners
github-actions
bot
added
the
product:hyperdrive
Oxyjun
reviewed
Nov 25, 2024
Comment on lines
29
to
31
| 3. Click on the elephant, and you'll see a connection string show up. | ||
| 4. If you want a new pair of credentials for use with Cloudflare Hyperdrive (recommended!), click on "Generate credentials". | ||
| 5. Copy the connection string without the "psql" part |
Contributor
There was a problem hiding this comment.
Suggested change
| 3. Click on the elephant, and you'll see a connection string show up. | |
| 4. If you want a new pair of credentials for use with Cloudflare Hyperdrive (recommended!), click on "Generate credentials". | |
| 5. Copy the connection string without the "psql" part | |
| 3. Select the PostgreSQL logo to show the connection string. | |
| 4. Select "Generate credentials" to generate new credentials. | |
| 5. Copy the connection string (without the "psql" part). |
Co-authored-by: Jun Lee <[email protected]>
Co-authored-by: Jun Lee <[email protected]>
Co-authored-by: Jun Lee <[email protected]>
Co-authored-by: Jun Lee <[email protected]>
Contributor
Author
|
Thanks for all the feedback, guys. It is much more readable now! |
thomasgauvin
approved these changes
Nov 25, 2024
Contributor
Thanks for the contribution! I had started poking around with Nile postgres last week, so this is good timing! |
Contributor
Thanks for the PR! We're running the pipeline now to merge :D |
workers-devprod
added
the
contribution
|
Congratulations @gwenshap, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm3xafebq08140clff1mgqtbw This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Adding Hyperdrive example with Nile database * small style change * Update Nile's hyperdrive doc per Oxyjun suggestions Co-authored-by: Jun Lee <[email protected]> * Update Nile's hyperdrive doc per Oxyjun suggestions Co-authored-by: Jun Lee <[email protected]> * Update Nile's hyperdrive doc per Oxyjun suggestions Co-authored-by: Jun Lee <[email protected]> * Update Nile's hyperdrive doc per Oxyjun suggestions Co-authored-by: Jun Lee <[email protected]> * Update Nile's hyperdrive example per thomasgauvin feedback --------- Co-authored-by: Jun Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding an example of using Hyperdrive with Nile database
Documentation checklist